Skip to content

[cyberarkpas] Handle syslog header in the monitor data stream #16739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chrisberkhout wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[cyberarkpas] Handle syslog header in the monitor data stream #16739

chrisberkhout wants to merge 3 commits into from
+35 −6

Conversation

@chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Dec 31, 2025 •
edited
Loading

Proposed commit message

[cyberarkpas] Handle syslog header in the monitor data stream

This matches the handling in the audit data stream, and should work with
or without the syslog header.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout self-assigned this Dec 31, 2025
@chrisberkhout chrisberkhout requested a review from a team as a code owner December 31, 2025 10:07
@chrisberkhout chrisberkhout added enhancement New feature or request Integration:cyberarkpas CyberArk Privileged Access Security Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 31, 2025
@elasticmachine
Copy link

elasticmachine commented Dec 31, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 31, 2025

🚀 Benchmarks report

Package cyberarkpas 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
monitor 10101.01 8196.72 -1904.29 (-18.85%) 💔

To see the full report comment with /test benchmark fullreport

ShourieG
ShourieG reviewed Jan 2, 2026
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test with syslog headers present ?

@chrisberkhout
Copy link
Contributor Author

chrisberkhout commented Jan 2, 2026

Can we add a test with syslog headers present ?

👍 in new commit.

@chrisberkhout chrisberkhout requested a review from ShourieG January 2, 2026 09:13
@chrisberkhout chrisberkhout enabled auto-merge (squash) January 2, 2026 09:13
@elasticmachine
Copy link

elasticmachine commented Jan 2, 2026 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @chrisberkhout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShourieG ShourieG Awaiting requested review from ShourieG

At least 1 approving review is required to merge this pull request.

Assignees

@chrisberkhout chrisberkhout

Labels

enhancement New feature or request Integration:cyberarkpas CyberArk Privileged Access Security Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisberkhout @elasticmachine @ShourieG