IconGroup: change focused style #439
Conversation
wpkelso
left a comment
wpkelso
left a comment
There was a problem hiding this comment.
I like this much better than the dot
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
LGTM just a few code nits :)
|
@leolost2605 changed these are to handle on notify state instead of overwriting. That's way smarter! Thanks for the review :) |
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
The dynamic workspace icon now doesn't get the focus style but apart from that looks great!
|
@leolost2605 do you mean the new workspace icon? I don't think that got a running indicator either. There should be no changes here to the logic of which thing gets an indicator, just styling |
|
@danirabbit can't test rn but I think it sets its active state which on main would cause the indicator to appear? But I'm not sure and either way we can leave it to a follow up :) |
Alternative idea for workspace focus styles so we're not conflating
runningwithfocusedFixes #399