Support infinite intervals #759
Merged
+154
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 20, 2026
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
I am a bit torn if we should do it like this or encode them in Postrex.Interval. Or perhaps make them opt-in?
Member
|
Ah, yes, we do this for timestamps: So we shoud have |
Member
Author
|
@josevalim done! |
josevalim
reviewed
Jan 20, 2026
lib/postgrex/extensions/interval.ex
Outdated
| other -> | ||
| raise ArgumentError, | ||
| "#{inspect(other)} is not valid for `:interval_decode_type`. Please use either `Postgrex.Interval` or `Duration`" | ||
| unless type in [Postgrex.Interval, Duration] do |
Member
There was a problem hiding this comment.
Suggested change
| unless type in [Postgrex.Interval, Duration] do | |
| if type not in [Postgrex.Interval, Duration] do |
josevalim
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of people asking for this so I took a stab.
There is one thing I think can be debated. For timestamps we have an option to opt into infinity values. I'm not 100% sure the reason so I'm not sure if it's the right thing to do for intervals.
One reason I can see for adding an option is if people were using these values in the past as a proxy for +/- infinity and now they will be returned as atoms instead of structs. But on the flipside most people will probably want the atoms if they are using this behaviour and if we make it opt in it will be more annoying. So I was thinking it might make sense to leave it like this and then add an opt out option if people are having issues.