-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[New Product] Hibernate #8747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[New Product] Hibernate #8747
Conversation
chenrui333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for Hibernate ORM, including release information, support policies, and version metadata for the popular Java persistence framework.
Key changes:
- New product page for Hibernate ORM with metadata configuration
- Release history covering versions 5.4 through 7.2 with Java and Jakarta EE compatibility details
- Custom fields for tracking supported JDK and Jakarta EE versions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcwrobel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kmoens for this contribution.
Here is my review., with my main feedback being:
- there should be a notion of "active support" (through the use of the
eoasColumn) and "limited support" (through the use of theeoasColumn) - the description should summarize the support policy, not just giving a few links. Based on what I understood only the latest release (aka series) is actively supported, and a few selected releases (chosen by the team on unknown criteria) receive limited support.
| - releaseCycle: "7.2" | ||
| supportedJavaVersions: "17, 21 or 23" | ||
| supportedJakartaEEVersions: "11" | ||
| releaseDate: 2025-10-08 | ||
| eol: false | ||
| latest: "7.2.0.CR1" | ||
| latestReleaseDate: 2025-10-08 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - releaseCycle: "7.2" | |
| supportedJavaVersions: "17, 21 or 23" | |
| supportedJakartaEEVersions: "11" | |
| releaseDate: 2025-10-08 | |
| eol: false | |
| latest: "7.2.0.CR1" | |
| latestReleaseDate: 2025-10-08 |
Only GA releases must be documented on endoflife.date.
| auto: | ||
| methods: | ||
| - git: https://github.com/hibernate/hibernate-orm.git | ||
| regex: '^(?P<major>[1-9]\d*)\.(?P<minor>\d+)\.(?P<patch>\d+)$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| regex: '^(?P<major>[1-9]\d*)\.(?P<minor>\d+)\.(?P<patch>\d+)$' |
The default regex will work for Hibernate versions, not need to override it.
| > The [Hibernate ORM](https://hibernate.org) object relational mapping (ORM) framework for Java | ||
| > simplifies database interactions using the Java Persistence API (JPA). | ||
|
|
||
| See [Hibernate ORM releases page](https://hibernate.org/orm/releases/) for release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given https://hibernate.org/community/maintenance-policy/ document stable and limited-support, this means that there are two level of support for releases :
- full, with bug and security fixes,
- limited, with a selection of bug and security fixes.
This must be reflected here with the use of eoasColumn / eolColumn. More on https://endoflife.date/contribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all releases receive limited support from what I can see on https://hibernate.org/orm/releases/. How such releases are chosen ?
| > simplifies database interactions using the Java Persistence API (JPA). | ||
|
|
||
| See [Hibernate ORM releases page](https://hibernate.org/orm/releases/) for release | ||
| information and [Hibernate ORM maintenance policy](https://hibernate.org/community/maintenance-policy/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://hibernate.org/community/maintenance-policy/ says:
Most Hibernate projects limit full maintenance to just the latest series; Hibernate Validator maintains multiple series.
It seems to apply to https://hibernate.org/orm/releases/, so I think it should be documented here.
| information and [Hibernate ORM maintenance policy](https://hibernate.org/community/maintenance-policy/) | ||
| for more details about supported releases. | ||
|
|
||
| Commercial support is available [from Red Hat](https://hibernate.org/orm/support/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the advantages of commercial support compared to standard support ? Longer support period ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| supportedJavaVersions: "8, 11 or 17" | ||
| supportedJakartaEEVersions: "8" | ||
| releaseDate: 2018-12-12 | ||
| eol: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, having dates for eol would be better. Are EOL of releases announced somewhere ?
Added information for Hibernate ORM.