Add tests for negative members in generated enumerations. #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor `test_enums_in_friendly_mod` in `comtypes/test/test_client.py` to: - Utilize a parameterized approach to test both `Scripting.StandardStreamTypes` and `WindowsInstaller.MsiInstallState`. - Verify enum member presence and value consistency between the generated enum types and `comtypes.client.Constants`. - Employ `subTest` for granular failure reporting in parameterized tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
=======================================
Coverage 85.30% 85.31%
=======================================
Files 126 126
Lines 11936 11941 +5
=======================================
+ Hits 10182 10187 +5
Misses 1754 1754 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a critical test that ensures
comtypes-generated enumeration members consistently return values dictated by their COM type information.The tests covers the scenario of COM enums containing negative values, which was not comprehensively addressed by previous tests.
The issue with
IntFlagin Python 3.15+(#894) highlighted a gap in our testing.By verifying this fundamental behavior, we guarantee that COM interoperability remains reliable, irrespective of CPython version updates or library-specific changes.