Avoid leaking user existence info #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
reviewed
Jun 3, 2024
| FAKE_USER_COUNT = 1000 | ||
|
|
||
|
|
||
| def fake_user(username: str) -> UserType: |
Member
There was a problem hiding this comment.
It's a good idea, but this is unfortunately not effective.
The returned user id is random every time, so just hit this API twice to check for existence. Additionally, I haven't had the time to analyze the using of static pubkeys/salts but I'm concerned that may have issues too.
Author
There was a problem hiding this comment.
The returned user id is random every time, so just hit this API twice to check for existence.
Oh, you are absolutely right, didn't think of that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #179 by returning a fake user instead of an error when no user with the requested username exists