-
Notifications
You must be signed in to change notification settings - Fork 85
Remove incorrect async engine keepalive settings #7171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7171 +/- ##
==========================================
+ Coverage 87.17% 87.20% +0.02%
==========================================
Files 535 535
Lines 35330 35315 -15
Branches 4113 4107 -6
==========================================
- Hits 30800 30797 -3
+ Misses 3639 3630 -9
+ Partials 891 888 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamsachs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup here!
| # Note: We purposely do not include async engine equivalents of the sync engine's | ||
| # keepalives_* settings as they are not supported by asyncpg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Greptile SummaryRemoved async engine keepalive configuration settings that were incompatible with
The changes fix a runtime error ( Confidence Score: 5/5
Important Files Changed
|
Ticket []
Description Of Changes
Removes some async engine settings that don't work when you set them, since they're not supported by
asyncpg; setting them causes the following error:These settings were originally added in #6128 but that PR seems to only care about the
pool_pre_pingsetting which does work as usual.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works