Mount PYTHONPATH on windows as unix paths #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G4Vi
approved these changes
Jan 22, 2025
Contributor
G4Vi
left a comment
G4Vi
left a comment
There was a problem hiding this comment.
LGTM, great work! It's unfortunate Wizer appears to have no way to specify an initial env instead of inherit host, so it looks like tampering with the host env is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHONPATHS on windows is separated by a
;instead of a:unlike unix systems. Which causes splitting of PYTHONPATH to failE.g
C:\\python3\\Lib\\site-packageswould be split into[C, \\python3...]The splitting should instead be done using
std::env::split_pathswhich makes use of the platform specific env separator.The second issue is mounting windows named paths in wizer. I believe mounting
C:\\python3\\Lib\\site-packagesjust doesn't work. Instead, convert the path to unix style (i.eC:\\python3\\Lib\\site-packagesbecomes/python3/Lib/site-packages) and then update the PYTHONPATH env var accordingly.