Skip to content

Conversation

@shrutipatel31
Copy link
Contributor

Summary: When get_trace returns all infeasible points (represented as inf or -inf values), the utility progression plot would previously attempt to plot these infinite values. This change adds a check to raise an ExperimentNotReadyError with a clear message when all trials are infeasible, preventing the plot from displaying meaningless data.

Differential Revision: D91751120

Summary: When `get_trace` returns all infeasible points (represented as `inf` or `-inf` values), the utility progression plot would previously attempt to plot these infinite values. This change adds a check to raise an `ExperimentNotReadyError` with a clear message when all trials are infeasible, preventing the plot from displaying meaningless data.

Differential Revision: D91751120
@meta-codesync
Copy link

meta-codesync bot commented Jan 29, 2026

@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91751120.

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 29, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.74%. Comparing base (5190f4b) to head (ccb4851).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4837   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         588      588           
  Lines       61526    61537   +11     
=======================================
+ Hits        59524    59535   +11     
  Misses       2002     2002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants