Skip to content

Improve robustness and fix minor typo #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SajanGhimire1 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Improve robustness and fix minor typo #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cachelib/cachebench/vizualize/extract_latency.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Note:
# For an even number of samples, this function returns the lower-middle
# value instead of averaging the two middle values. This is intentional
# for operational latency analysis.


input_logfile=$1
Expand Down Expand Up @@ -54,7 +58,7 @@ extract_latency() {

# check if the file actually produced valid content
[[ "$(wc -l < "$out")" -eq "1" ]] && \
echo "Incorrect log file. No latecny records found" || \
echo "Incorrect log file. No latency records found" || \
echo "$search latency written to $out"
}

Expand All @@ -74,7 +78,8 @@ extract_bandwidth() {
# get the bandwidth
grep -e "$search" "$in" | \
tail -1 | \
awk '{print $10 " " $13}'
awk -F '[ ,]+' '{for(i=1;i<=NF;i++) if($i=="egressBytesPerSec") print $(i+2), $(i+5)}'

} | column -t > "$out"

# check if the file actually produced valid content
Expand Down