FCE-2609 Add channel notification messages #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qizot
changed the title
Qizot
force-pushed
the
channel-notifications
branch
from
9aeaba2 to
40512a6
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds channel notification support to the Fishjam server messaging protocol by introducing ChannelAdded and ChannelRemoved message types that notify when peers create or delete channels in rooms.
- Adds two new protobuf message types:
ChannelAddedandChannelRemoved - Updates the
ServerMessageoneof to include the new channel notification fields - Updates documentation to reflect the new message types
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| fishjam/server_notifications.proto | Defines the new ChannelAdded and ChannelRemoved protobuf messages and adds them to the ServerMessage oneof |
| fishjam_protos/lib/fishjam/server_notifications.pb.ex | Generated Elixir code from the protobuf definitions for the new channel notification messages |
| doc/docs.md | Documentation for the new channel notification message types including field descriptions |
| README.md | Adds instructions for generating Elixir protos with the required protobuf plugin |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Karolk99
approved these changes
Jan 12, 2026
Qizot
force-pushed
the
channel-notifications
branch
2 times, most recently
from
30097c5 to
4749077
Compare
Qizot
force-pushed
the
channel-notifications
branch
from
4749077 to
5394cf1
Compare
Karolk99
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds channel notifications to the server messages.
Motivation and Context
Documentation impact