fix: sent emails not showing up #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where sent emails were not showing up in the sent mailbox view. The root cause was that the email filtering logic was checking if the user was a recipient of the email, which doesn't apply to sent emails where the user is the sender.
Changes:
- Added logic to differentiate between sent mailboxes and inbox/other mailboxes
- For sent mailboxes, the filter now checks if the sender matches the configured fetch email
- For inbox and other mailboxes, the filter continues to check if any recipient matches the configured fetch email
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+213
to
+217
| if isSentMailbox { | ||
| // For sent mailbox, check if the sender matches the fetchEmail | ||
| if strings.EqualFold(strings.TrimSpace(fromAddr), fetchEmail) { | ||
| matched = true | ||
| break | ||
| } |
There was a problem hiding this comment.
The new filtering logic for sent mailboxes lacks test coverage. Since the repository has existing tests for the FetchEmails function, consider adding test coverage for FetchSentEmails to verify that the sent mailbox filtering correctly matches emails where the sender is the configured fetch email address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailbox filtering improvements:
fetcher/fetcher.go, the code now checks if the mailbox is the sent mailbox and, if so, filters emails by matching the sender address to the account email. For all other mailboxes, it continues to filter by matching any recipient address to the account email.