Skip to content

Conversation

@mys007
Copy link
Contributor

@mys007 mys007 commented Jul 29, 2025

Why are the changes needed?

"audience" is a valid field in config.yaml but it's value is not taken into account when creating PlatformConfig. This seems to be an omission error.

What changes were proposed in this pull request?

This fix loads the the field value.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request fixes a bug related to the 'audience' field in the configuration file, ensuring it is utilized in the creation of PlatformConfig. This enhancement improves the flexibility and usability of configuration management for authentication flows.

@welcome
Copy link

welcome bot commented Jul 29, 2025

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@mys007 mys007 changed the title Bugfix: reading "audience" from Bugfix: "audience" from config.yaml Jul 29, 2025
Signed-off-by: Martin Simonovsky <martin.simonovsky@aleph-alpha-ip.ai>
@mys007 mys007 force-pushed the audience-in-configuration branch from 9248c7f to 1747ba8 Compare July 29, 2025 19:15
@pingsutw pingsutw requested a review from machichima as a code owner January 30, 2026 07:19
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw merged commit 0e9b58c into flyteorg:master Jan 30, 2026
2 checks passed
@welcome
Copy link

welcome bot commented Jan 30, 2026

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants