Skip to content

Prepare for ggplot2 v4 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbstadler merged 19 commits into from
Sep 12, 2025
Merged

Prepare for ggplot2 v4 #90

mbstadler merged 19 commits into from
Sep 12, 2025

Conversation

@mbstadler
Copy link
Collaborator

@mbstadler mbstadler commented Jul 10, 2025

No description provided.

@mbstadler mbstadler requested review from csoneson and machlabd July 10, 2025 15:08
@mbstadler
Copy link
Collaborator Author

mbstadler commented Jul 10, 2025 •
edited
Loading

I have temporarily added a step to the github actions to install the devel version of ggplot2, as well as a version requirement for ggplot2 (>= 3.5.2.9001) to the DESCRIPTION. This was mostly required due to the changes in geom_violin (deprecation of draw_quantiles in favor of quantiles and quantile.linetype, etc.), which means that there is no way to implement quantile drawing to work for both pre- and post-v4 ggplot2.

Before we merge (once ggplot2 4.0.0 is out), we may want to:

  • remove the installation of devel ggplot2 from the github actions
  • change the version requirement for ggplot2 in DESCRIPTION from >= 3.5.2.9001 to >= 4.0.0

csoneson
csoneson approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@csoneson csoneson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I just changed the tests for ggplot objects as recommended in tidyverse/ggplot2#6498 (the other way still works for now, but may be removed in the future)

machlabd
machlabd approved these changes Jul 11, 2025
View reviewed changes
Copy link
Collaborator

@machlabd machlabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've added some minor comments.

@mbstadler
Copy link
Collaborator Author

mbstadler commented Sep 12, 2025

As ggplot2 v4.0.0 is now available, I have removed the installation of ggplot2-devel on GHA and added ggplot2 >= 4.0.0 to DESCRIPTION, and will merge and push it upstream as soon as the tests are all green (except for the unrelated issue on bioconductor_docker)

@mbstadler mbstadler merged commit 8680623 into devel Sep 12, 2025
4 of 6 checks passed
@mbstadler mbstadler deleted the prepare-for-ggplot2-v4 branch September 12, 2025 08:39
@csoneson
Copy link
Collaborator

csoneson commented Sep 12, 2025

Great, thank you! 🎉

@machlabd
Copy link
Collaborator

machlabd commented Sep 12, 2025

Perfect, thank you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csoneson csoneson csoneson approved these changes

@machlabd machlabd machlabd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbstadler @csoneson @machlabd