Ivy wk1 hm wrk #1
Conversation
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
it seems like you have 2 .eslintrc.json, one is enough. You can have several eslint configuratons files if you want for example the project to follow some rules, but maybe tests should follow different rules.
| }, | ||
| "extends": "standard", | ||
| "globals": { | ||
| "Atomics": "readonly", |
There was a problem hiding this comment.
You are not using the variables declared here in the globals
| function createServer(port) { | ||
| let state = 10; | ||
| function showResponseToClient(response, state) { | ||
| response.setHeader('Content', 'application/json'); |
There was a problem hiding this comment.
Really awsome that you moved out this logic from the switch case! 🎊 Maybe you can take it one step further and move the fucntion completly out to be outside of the createServer function? Also I am missing a status code :)
Since you are suggesting in your eslint configuration that you use es6 ,if you feel like taking it even further, you really dont have to, is to make that into an arrow function.
2 participants
No description provided.