fix: add errdefer to prevent sessions_storage leak #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Memory leak when sessions allocation fails after sessions_storage is allocated but before the defer block is installed. Solution: Added errdefer to free sessions_storage immediately after its allocation. If the subsequent sessions allocation fails, errdefer ensures sessions_storage is freed. Once the defer block is installed, it takes over responsibility for freeing both allocations on normal exit paths.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 096bfe3fcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Scope the errdefer inside a labeled block so it only covers the gap between the two allocations. Once the block exits, the defer block takes sole ownership of freeing sessions_storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a memory leak in
src/app/runtime.zigwheresessions_storagewould leak if the subsequentsessionsallocation failed.Problem
The allocation sequence was:
sessions_storagesessionsdeferblock to free bothIf step 2 failed, the
deferblock would never be installed, leavingsessions_storageleaked.Solution
Added
errdefer allocator.free(sessions_storage);immediately after the first allocation. This ensures cleanup on any failure path before thedeferis installed. Once thedeferblock is registered, it takes over responsibility for freeing both allocations on normal exit paths.