Fix SQLite3 Cell data overflow reading for databases with header.reserved_size set
#25
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You know the question that's coming: is it possible to have some test data for this edge case? Also @PimSanders since you've been looking into SQLite for a little while now, what are your thoughts on this? |
Author
The PR for #17 will include test data that covers this change. |
Author
|
Added a separate test for this case in 3a09e78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
Cell.datareading for databases when parsing a cell value larger than the (usable) page size. Currently the overflow page lookup implementation does not calculate thedata_sizecorrectly for databases withheader.reserved_sizeset.