Skip to content

Conversation

@benedikt-haug
Copy link
Contributor

What this PR does / why we need it:
This PR is part of the Hackaton.
This PR allows the operator to hide elements of the NewShoot dialogue.

Without configuring anything, nothing should change. The end-result might be:
grafik

Special notes for your reviewer:
/cc @marc1404 @klocke-io

Release note:

Allow hiding parts of the newShoot dialogue

@gardener-robot
Copy link

@benedikt-haug Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2025
@gardener-robot-ci-1
Copy link
Contributor

Thank you @benedikt-haug for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@klocke-io klocke-io added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 5, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 5, 2025
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes sense together with PR #2476, however, I do not get the complete story. Is the goal to avoid overwhelming users when creating shoots and to control certain defaults (some of which cannot be changed after shoot creation), while giving users the freedom to change other settings later on (like hibernation, DNS config, addons, auto update)?

If there are CloudProfiles from different providers, I can change the infrastructure in the YAML tab. But this makes it confusing. Also you can create credentials for the infrastructure provider but you cannot select / change the infrastructure provider on the creation dialog. Or is the idea/recommendation to hide the infrastructure option only in landscapes where there is no other provider type?

@benedikt-haug
Copy link
Contributor Author

This PR makes sense together with PR #2476, however, I do not get the complete story. Is the goal to avoid overwhelming users when creating shoots and to control certain defaults (some of which cannot be changed after shoot creation), while giving users the freedom to change other settings later on (like hibernation, DNS config, addons, auto update)?
If there are CloudProfiles from different providers, I can change the infrastructure in the YAML tab. But this makes it confusing. Also you can create credentials for the infrastructure provider but you cannot select / change the infrastructure provider on the creation dialog. Or is the idea/recommendation to hide the infrastructure option only in landscapes where there is no other provider type?

The goals of this PR is for the operator to be able to gain by configuration:

  • free screen real estate if no choice is possible e.g. hide infrastructure section if only a single cloud provider exists or if choosing non-default isn't economically sensible
  • nudge novice users e.g. if high-availability is the configured default (possible by the other PR), disabling this is generally not intended by the cluster operator, thus hiding this section reduces potential for user errors
  • save explanation effort by hiding advanced usecases e.g. addons which aren't actually supported for production or workerless clusters which are mainly useful for development purposes

@gardener-robot
Copy link

@holgerkoser, @grolu, @klocke-io You have pull request review open invite, please check

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Oct 16, 2025
@gardener-robot
Copy link

@benedikt-haug You need rebase this pull request with latest master branch. Please check.

@grolu grolu added area/ipcei IPCEI (Important Project of Common European Interest) and removed area/ipcei IPCEI (Important Project of Common European Interest) labels Dec 1, 2025
@grolu grolu mentioned this pull request Dec 1, 2025
@gardener-ci-robot
Copy link
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-robot gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2025
@gardener-ci-robot
Copy link
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close

/lifecycle rotten

@gardener-robot gardener-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants