-
Notifications
You must be signed in to change notification settings - Fork 116
Feature hide elements of NewShoot dialogue #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature hide elements of NewShoot dialogue #2478
Conversation
|
@benedikt-haug Thank you for your contribution. |
|
Thank you @benedikt-haug for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
petersutter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes sense together with PR #2476, however, I do not get the complete story. Is the goal to avoid overwhelming users when creating shoots and to control certain defaults (some of which cannot be changed after shoot creation), while giving users the freedom to change other settings later on (like hibernation, DNS config, addons, auto update)?
If there are CloudProfiles from different providers, I can change the infrastructure in the YAML tab. But this makes it confusing. Also you can create credentials for the infrastructure provider but you cannot select / change the infrastructure provider on the creation dialog. Or is the idea/recommendation to hide the infrastructure option only in landscapes where there is no other provider type?
The goals of this PR is for the operator to be able to gain by configuration:
|
|
@holgerkoser, @grolu, @klocke-io You have pull request review open invite, please check |
|
@benedikt-haug You need rebase this pull request with latest master branch. Please check. |
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle rotten |
What this PR does / why we need it:
This PR is part of the Hackaton.
This PR allows the operator to hide elements of the NewShoot dialogue.
Without configuring anything, nothing should change. The end-result might be:

Special notes for your reviewer:
/cc @marc1404 @klocke-io
Release note: