Skip to content

feat(actions): use javascript-sdk-gitflow app instead of personal token #18829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oioki wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −5
Open

feat(actions): use javascript-sdk-gitflow app instead of personal token #18829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/external-contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,17 @@ jobs:
name: ${{ github.event.pull_request.user.login }}
author_association: ${{ github.event.pull_request.author_association }}

- name: Generate GitHub App token
id: app-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ vars.GITFLOW_APP_ID }}
private-key: ${{ secrets.GITFLOW_APP_PRIVATE_KEY }}

- name: Create PR with changes
uses: peter-evans/create-pull-request@98357b18bf14b5342f975ff684046ec3b2a07725
with:
# This token is scoped to Daniel Griesser
# If we used the default GITHUB_TOKEN, the resulting PR would not trigger CI :(
token: ${{ secrets.REPO_SCOPED_TOKEN }}
token: ${{ steps.app-token.outputs.token }}
commit-message: 'chore: Add external contributor to CHANGELOG.md'
title: 'chore: Add external contributor to CHANGELOG.md'
branch: 'external-contributor/patch-${{ github.event.pull_request.user.login }}'
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/gitflow-sync-develop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ jobs:
- name: git checkout
uses: actions/checkout@v6

- name: Generate GitHub App token
id: app-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ vars.GITFLOW_APP_ID }}
private-key: ${{ secrets.GITFLOW_APP_PRIVATE_KEY }}

# https://github.com/marketplace/actions/github-pull-request-action
- name: Create Pull Request
id: open-pr
Expand All @@ -35,8 +42,7 @@ jobs:
pr_title: '[Gitflow] Merge ${{ env.SOURCE_BRANCH }} into ${{ env.TARGET_BRANCH }}'
pr_body: 'Merge ${{ env.SOURCE_BRANCH }} branch into ${{ env.TARGET_BRANCH }}'
pr_label: 'Dev: Gitflow'
# This token is scoped to Daniel Griesser
github_token: ${{ secrets.REPO_SCOPED_TOKEN }}
github_token: ${{ steps.app-token.outputs.token }}

- name: Enable automerge for PR
if: steps.open-pr.outputs.pr_number != ''
Expand Down
Loading