-
Notifications
You must be signed in to change notification settings - Fork 252
update rubocop configuration for CI #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a9ace08 to
0fc7ed6
Compare
35a4d57 to
d958229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Rubocop configuration to prevent lint errors from blocking CI until Ruby 4.0 support work and linting cleanup can be completed. The changes temporarily disable several style and lint cops while also updating a test to use public_send instead of send to address GitHub's custom linting rule.
- Disables five Rubocop cops that were causing CI failures across different Ruby versions
- Changes method invocation from
sendtopublic_sendin a spec test for public attribute access - Sets TargetRubyVersion to 2.6 to ensure consistent linting behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .rubocop.yml | Adds configuration to disable five cops (Style/ClassMethodsDefinitions, Style/OrAssignment, Layout/SpaceInsideHashLiteralBraces, Lint/ParenthesesAsGroupedExpression, Lint/RedundantCopDisableDirective) and sets TargetRubyVersion to 2.6 |
| spec/lib/secure_headers/configuration_spec.rb | Updates test to use public_send instead of send for accessing public attributes, with inline cop disablement for GitHub/AvoidObjectSendWithDynamicMethod |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Lint/RedundantCopDisableDirective: | ||
| Enabled: false |
Copilot
AI
Dec 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling the Lint/RedundantCopDisableDirective cop will hide instances where rubocop disable directives are no longer needed. This makes it harder to maintain clean code and remove outdated suppressions over time. Consider keeping this cop enabled to track when directives become redundant as rules change.
| Lint/RedundantCopDisableDirective: | |
| Enabled: false |
Updates our rubocop config to prevent lint errors from blocking CI.
Once #560 is unblocked we can focus on Ruby 4.0 support and cleaning up the linting rules that were disabled in this PR.
All PRs: