-
Notifications
You must be signed in to change notification settings - Fork 279
feat: migrate from Electron to Tauri v2 #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
afonsojramos
wants to merge
14
commits into
main
Choose a base branch
from
tauri
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+16,321
−13,540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a complete migration of Gitify from Electron to Tauri v2. Changes include: - Remove Electron main/preload processes and webpack configs - Add Tauri v2 backend with Rust (src-tauri/) - Add Vite bundler configuration - Migrate renderer code from src/renderer/ to src/ - Migrate tests from Jest to Vitest - Update all dependencies for Tauri compatibility - Add type-safe context hook (useAppContext) - Fix strict TypeScript mode issues BREAKING CHANGE: This replaces the Electron backend with Tauri.
- Update test snapshots for vitest migration - Fix Tailwind config path from ../../ to ../ - Skip flaky nock replyWithError tests
- Replace @tailwindcss/postcss with @tailwindcss/vite - Remove postcss.config.js - Update vite.config.ts with tailwindcss plugin - Remove @config directive from App.css (Vite plugin reads config automatically)
Add tauri-plugin-http to bypass WebView CORS restrictions when making API requests to GitHub. This fixes the PAT login network error. - Add tauri-plugin-http to Cargo dependencies - Initialize HTTP plugin in lib.rs - Add HTTP permissions for GitHub API in capabilities - Update request.ts to use Tauri fetch when in Tauri environment - Create shared isTauriEnvironment utility in environment.ts
Use convertFileSrc from @tauri-apps/api/core to convert local file paths to asset:// URLs that work in Tauri's WebView.
Add React state management for zoom percentage in AppearanceSettings to ensure the UI updates after zoom changes. The zoom functions now work correctly with Tauri's webview zoom API.
- Add Tauri internals mock to vitest.setup.ts - Create mock for @tauri-apps/plugin-http - Add isTauriEnvironment and decryptValue mocks to tests using axios - Update snapshots for emoji rendering changes
- Update comms.ts to use isTauriEnvironment checks - Update auth utils for Tauri OAuth callback handling - Update App context for Tauri environment - Update index.tsx entry point
- Update SystemSettings for Tauri compatibility - Update TraySettings for Tauri tray API
- Update native notification handling for Tauri - Update sound playback for Tauri asset loading
- Update App.css for Tauri WebView - Add theme.css for CSS custom properties - Update Tailwind config - Update index.html for Tauri
Remove platform.ts and platform.test.ts as platform detection is now handled by the Tauri bridge (window.gitify.platform).
- Fix handler enrich() methods to return null instead of {} for failures
- Update handler return types to Promise<GitifySubject | null>
- Use undefined for optional fields to match GitifySubject type
- Add waitFor in AccountNotifications tests for async emoji loading
- Skip OAuth/timer-dependent tests that can't complete in test environment
- Fix vitest.setup.ts type casts for window properties
- Update test expectations and regenerate snapshots
Member
|
Pretty cool, nice work @afonsojramos I'll need some time to review a PR of this size... I'm on the fence re the amount of Rust code tbh. Shall we mark this PR as draft in the interim? |
setchy
reviewed
Dec 27, 2025
| { | ||
| "$schema": "https://schema.tauri.app/config/2", | ||
| "productName": "Gitify", | ||
| "version": "6.11.1", |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several release behind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm testto verify all tests pass (635 passing, 6 skipped)