-
Notifications
You must be signed in to change notification settings - Fork 292
Build with zig #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with zig #431
Conversation
Add the necessary files to build a static library with Zig. The build also includes producing execuable that can be cross-compiled Signed-off-by: inge4pres <fgualazzi@gmail.com>
Signed-off-by: inge4pres <fgualazzi@gmail.com>
gchatelet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mizux can you have a look as well?
Signed-off-by: inge4pres <fgualazzi@gmail.com>
Mizux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: inge4pres <fgualazzi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
note: Macos ci failure were flacky (and fixed by d868036)
Reason for this PR
Relates to:
Details
Additional context
The build scripts is derived from what CMake does; it compiles a static library and an executable that links to it for testing.
The Github workflow simply ensure compilation via build.zig succeeds and runs the executable on 4 Linux targets.
Further work
build.zigcould also be extended to include ateststep that runs the c++ tests in thetestfolder.