Move to using objc_externally_retained to elide unneeded calls to retain/release in j2objc protobuf code.
#2637
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etain/release in j2objc protobuf code. I believe all of the C code that is wrapped in these blocks can assume that the objects being passed in are going to be held externally and will live for the lifetime of the call. https://clang.llvm.org/docs/AutomaticReferenceCounting.html#externally-retained-variables PiperOrigin-RevId: 841790480
copybara-service
bot
force-pushed
the
test_841790480
branch
from
808a181 to
eae690b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to using
objc_externally_retainedto elide unneeded calls to retain/release in j2objc protobuf code.I believe all of the C code that is wrapped in these blocks can assume that the objects being passed in are going to be held externally and will live for the lifetime of the call.
https://clang.llvm.org/docs/AutomaticReferenceCounting.html#externally-retained-variables