-
Notifications
You must be signed in to change notification settings - Fork 36
fix(legacy-librarian): add support for pre-release versions #3305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: legacy-librarian
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a known bug by enhancing the system's semantic versioning parser to correctly interpret and process versions that include pre-release identifiers. This ensures that the application can properly handle a wider range of version strings, improving compatibility and robustness when dealing with software releases that follow the semantic versioning specification, including pre-release stages. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully addresses the issue of supporting pre-release versions by updating the semantic versioning regular expressions in both the config and semver packages. The addition of comprehensive test cases in semver_test.go thoroughly validates the new parsing logic for various pre-release formats. The changes are well-implemented and directly resolve the reported bug.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## legacy-librarian #3305 +/- ##
=================================================
Coverage 83.01% 83.01%
=================================================
Files 140 140
Lines 11089 11089
=================================================
Hits 9205 9205
Misses 1466 1466
Partials 418 418 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ldetmer, @miguelvelezsa Please could you take another look? |
Fixes #3304
a,b,alpha,beta,previewandrc