Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Dec 18, 2025

Fixes #3304

  • As per the linked bug, this PR adds support to pre-release version suffixes such as a, b, alpha, beta, preview and rc

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a known bug by enhancing the system's semantic versioning parser to correctly interpret and process versions that include pre-release identifiers. This ensures that the application can properly handle a wider range of version strings, improving compatibility and robustness when dealing with software releases that follow the semantic versioning specification, including pre-release stages.

Highlights

  • Pre-release Version Support: This pull request introduces support for parsing and recognizing pre-release version suffixes in semantic versioning, such as 'alpha', 'beta', 'rc', 'preview', 'a', and 'b'.
  • Regular Expression Updates: The semverRegex in both internal/config/state.go and internal/semver/semver.go has been updated to correctly match and extract pre-release identifiers, including cases where the hyphen before the pre-release tag is optional.
  • Expanded Test Coverage: Numerous new test cases have been added to internal/semver/semver_test.go to thoroughly validate the parsing logic for various pre-release version formats, ensuring robust handling of these versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully addresses the issue of supporting pre-release versions by updating the semantic versioning regular expressions in both the config and semver packages. The addition of comprehensive test cases in semver_test.go thoroughly validates the new parsing logic for various pre-release formats. The changes are well-implemented and directly resolve the reported bug.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.01%. Comparing base (cd2252e) to head (8dd7a6a).
⚠️ Report is 1 commits behind head on legacy-librarian.

Additional details and impacted files
@@                Coverage Diff                @@
##           legacy-librarian    #3305   +/-   ##
=================================================
  Coverage             83.01%   83.01%           
=================================================
  Files                   140      140           
  Lines                 11089    11089           
=================================================
  Hits                   9205     9205           
  Misses                 1466     1466           
  Partials                418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@parthea parthea marked this pull request as ready for review December 18, 2025 20:09
@parthea parthea requested a review from a team as a code owner December 18, 2025 20:09
@parthea parthea self-assigned this Dec 18, 2025
@parthea parthea assigned ldetmer and miguelvelezsa and unassigned parthea Dec 19, 2025
@parthea
Copy link
Contributor Author

parthea commented Dec 19, 2025

@ldetmer, @miguelvelezsa Please could you take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants