feat: Add dark mode to anywidget mode #2365
Merged
+713
−603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates table_widget.css to use CSS variables for colors where possible.
- Adds @media (prefers-color-scheme: dark) block to handle dark mode overrides.
- Updates text and background colors to be legible in dark mode.
- Adds unit test to verify CSS contains dark mode media query.
- Update TableWidget CSS with variables and media queries for dark mode. - Pass CSS content via a new 'css_styles' traitlet to ensure reliable loading. - Implement robust JavaScript logic to detect VS Code dark themes and recursively clear ancestor backgrounds, eliminating the 'white frame' issue. - Reformat CSS and JS files to comply with project style guides. - Add unit test for CSS traitlet population.
product-auto-label
bot
added
size: l
shuoweil
changed the title
shuoweil
commented
Jan 6, 2026
Contributor
Author
There was a problem hiding this comment.
I did not rewrite this file, I just reformat this file. In addition to the reformatting, a new set of tests for the dark mode "Theme detection" feature was also added. The newly added tests in table_widget.test.js are:
- should add bigframes-dark-mode class in dark mode
- should not add bigframes-dark-mode class in light mode
product-auto-label
bot
added
size: xl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table now automatically adapts to dark and light themes in environments like Colab and VS Code for anywidget mode.
Verified at:
Fixes #<460861328> 🦕