Skip to content

upgrade: v1.17.0 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hwbrzzl wants to merge 2 commits into
base: v1.16.x
Choose a base branch
from
Draft

upgrade: v1.17.0 #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0f6b8e
upgrade: v1.17.0
hwbrzzl Jan 13, 2026
21776e7
optimize
hwbrzzl Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
.idea
.vscode
.DS_Store
storage/framework
launch.json
.env
.env.*
!.env.example
storage
tmp
23 changes: 23 additions & 0 deletions config/mail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,28 @@ func init() {
"username": config.Env("MAIL_USERNAME"),

"password": config.Env("MAIL_PASSWORD"),

// Template Configuration
//
// This controls template rendering for email views. Template engines are cached
// globally and support both built-in drivers and custom implementations via factories.
//
// Available Drivers: "html", "custom"
"template": map[string]any{
"default": config.Env("MAIL_TEMPLATE_ENGINE", "html"),
"engines": map[string]any{
"html": map[string]any{
"driver": "html",
"path": config.Env("MAIL_VIEWS_PATH", "resources/views/mail"),
},
// Example custom template engine:
// "blade": map[string]any{
// "driver": "custom",
// "via": func() (mail.Template, error) {
// return NewBladeTemplateEngine(), nil
// },
Comment on lines +59 to +61
Copy link

@gemini-code-assist gemini-code-assist bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The example for a custom template engine is a great addition. However, if a developer uncomments it as-is, the code will fail to compile because mail.Template is an unresolved reference and NewBladeTemplateEngine is undefined. To improve the developer experience and make this example more self-contained, I suggest adding inline comments to guide the user on what needs to be imported and implemented.

Suggested change
// "via": func() (mail.Template, error) {
// return NewBladeTemplateEngine(), nil
// },
// "via": func() (mail.Template, error) { // `mail` is from "github.com/goravel/framework/contracts/mail"
// return NewBladeTemplateEngine(), nil // `NewBladeTemplateEngine` is your implementation.
// },

// },
},
},
})
}
Loading