Skip to content

Conversation

@msaroufim
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 14, 2026 00:54
@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements dynamic GPU runner selection to enable concurrent GitHub Actions workflow runs across multiple GPUs. Instead of using a single fixed runner, the workflow now distributes jobs across 5 different GPU runners using a round-robin selection based on the GitHub run number.

Changes:

  • Added a select-runner job that picks one of 5 available GPU runners using modulo-based distribution
  • Updated the main run job to use the dynamically selected runner and added concurrency controls per runner

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

runner: ${{ steps.pick.outputs.runner }}
steps:
- id: pick
run: |
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner list skips gpu1, gpu3, and gpu6 without explanation. Consider adding a comment explaining why these specific GPUs are selected, or use a more consistent naming pattern if possible.

Suggested change
run: |
run: |
# Only schedule jobs on GPUs that are available for CI use.
# gpu1, gpu3, and gpu6 on b200-02 are reserved/unavailable, so they are intentionally excluded.

Copilot uses AI. Check for mistakes.
- id: pick
run: |
runners=("b200-02-gpu0" "b200-02-gpu2" "b200-02-gpu4" "b200-02-gpu5" "b200-02-gpu7")
index=$(( ${{ github.run_number }} % 5 ))
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modulo value is hardcoded as 5. If runners are added or removed from the array, this must be manually updated. Consider using ${#runners[@]} to automatically match the array length.

Suggested change
index=$(( ${{ github.run_number }} % 5 ))
index=$(( ${{ github.run_number }} % ${#runners[@]} ))

Copilot uses AI. Check for mistakes.
@msaroufim msaroufim merged commit 8ed6150 into main Jan 14, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants