Skip to content

Simplify NVIDIA workflow runner selection #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msaroufim merged 4 commits into from
Jan 14, 2026
Merged

Simplify NVIDIA workflow runner selection #400

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
223a9fe
GPU concurrency
msaroufim Jan 14, 2026
e5b72ea
update
msaroufim Jan 14, 2026
89007f1
Simplify NVIDIA workflow runner selection
msaroufim Jan 14, 2026
eabfcdf
Merge main and resolve conflicts
msaroufim Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions .github/workflows/nvidia_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,8 @@ on:
run-name: 'NVIDIA Job - ${{ github.event.inputs.run_id }}'

jobs:
select-runner:
runs-on: ubuntu-latest
outputs:
runner: ${{ steps.pick.outputs.runner }}
steps:
- id: pick
run: |
runners=("b200-02-gpu0" "b200-02-gpu1" "b200-02-gpu2" "b200-02-gpu3" "b200-02-gpu4" "b200-02-gpu5" "b200-02-gpu6" "b200-02-gpu7")
index=$(( ${{ github.run_number }} % 8 ))
echo "runner=${runners[$index]}" >> $GITHUB_OUTPUT

run:
needs: select-runner
runs-on: ${{ needs.select-runner.outputs.runner }}
concurrency:
group: ${{ needs.select-runner.outputs.runner }}
cancel-in-progress: false
runs-on: [self-hosted, nvidia-docker-b200-8-x86-64]
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the self-hosted label creates an inconsistency with other workflows in the repository. The workflows nvidia-on-prem-health.yml (line 12) and runner_ci.yml (lines 15 and 49) use the same runner label [nvidia-docker-b200-8-x86-64] without the self-hosted prefix. For consistency, either all workflows using this runner should include the self-hosted label, or none should. Additionally, the amd-health.yml workflow uses [amdgpu-mi300-8-x86-64] without self-hosted, suggesting a pattern in this repository of not including the self-hosted label explicitly.

Suggested change
runs-on: [self-hosted, nvidia-docker-b200-8-x86-64]
runs-on: [nvidia-docker-b200-8-x86-64]

Copilot uses AI. Check for mistakes.
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
Expand Down
Loading