Skip to content

Fix bug where challenge button should not be enabled when a project is not selected #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nieldlr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug where challenge button should not be enabled when a project is not selected #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui/src/components/Select/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ const Select = ({ items, variant, setValue }) => {
item={selected}
parent={selected.parent}
selected={selected}
setSelected={setSelected}
setSelected={item => {
setSelected(item);
setValue(item);
}}
sx={{ background: 'white', mx: 0, my: 3 }}
close={true}
variant={variant}
Expand Down
4 changes: 3 additions & 1 deletion ui/src/components/TabView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const TabView = ({
header,
placeholder,
heading,
projectId,
value,
setValue,
text,
Expand Down Expand Up @@ -98,7 +99,7 @@ const TabView = ({
text={text}
icon={icon}
sx={{ margin: ['auto', 'auto', 0] }}
disabled={value.length === 0}
disabled={value.length === 0 || !projectId}
/>
</Box>
</Grid>
Expand All @@ -115,6 +116,7 @@ TabView.propTypes = {
header: PropTypes.string,
placeholder: PropTypes.string,
heading: PropTypes.string,
projectId: PropTypes.string,
value: PropTypes.string,
setValue: PropTypes.func,
text: PropTypes.string,
Expand Down
1 change: 1 addition & 0 deletions ui/src/pages/project/template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,7 @@ const Project = ({ location }) => {
successfully curating the Everest registry.
</span>
}
projectId={challenge.projectId}
value={challenge.description}
setValue={setChallengeData}
text="Challenge"
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26136,16 +26136,18 @@ web3-net@1.2.6:
web3-core-method "1.2.6"
web3-utils "1.2.6"

web3-provider-engine@14.0.6, "web3-provider-engine@git+https://github.com/trufflesuite/provider-engine.git":
web3-provider-engine@14.0.6, "web3-provider-engine@https://github.com/trufflesuite/provider-engine#web3-one":
version "14.0.6"
resolved "git+https://github.com/trufflesuite/provider-engine.git#3538c60bc4836b73ccae1ac3f64c8fed8ef19c1a"
resolved "https://github.com/trufflesuite/provider-engine#9694f5b4e5500651bd2ff689df8529bb5cf6b96f"
dependencies:
async "^2.5.0"
backoff "^2.5.0"
clone "^2.0.0"
cross-fetch "^2.1.0"
eth-block-tracker "^3.0.0"
eth-block-tracker "^4.2.0"
eth-json-rpc-filters "^4.0.2"
eth-json-rpc-infura "^3.1.0"
eth-json-rpc-middleware "^4.1.1"
eth-sig-util "^1.4.2"
ethereumjs-block "^1.2.2"
ethereumjs-tx "^1.2.0"
Expand Down Expand Up @@ -26215,18 +26217,16 @@ web3-provider-engine@15.0.4:
xhr "^2.2.0"
xtend "^4.0.1"

"web3-provider-engine@https://github.com/trufflesuite/provider-engine#web3-one":
"web3-provider-engine@git+https://github.com/trufflesuite/provider-engine.git":
version "14.0.6"
resolved "https://github.com/trufflesuite/provider-engine#9694f5b4e5500651bd2ff689df8529bb5cf6b96f"
resolved "git+https://github.com/trufflesuite/provider-engine.git#3538c60bc4836b73ccae1ac3f64c8fed8ef19c1a"
dependencies:
async "^2.5.0"
backoff "^2.5.0"
clone "^2.0.0"
cross-fetch "^2.1.0"
eth-block-tracker "^4.2.0"
eth-json-rpc-filters "^4.0.2"
eth-block-tracker "^3.0.0"
eth-json-rpc-infura "^3.1.0"
eth-json-rpc-middleware "^4.1.1"
eth-sig-util "^1.4.2"
ethereumjs-block "^1.2.2"
ethereumjs-tx "^1.2.0"
Expand Down