feat: add support for tags #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@guyfedwards Alright I feel kinda dumb... I have no idea how the filtering works. I think my issue is that the tags don't exist in the text that is displayed, unlike the feed name. So when I try to filter by a tag, I just get no results 🙃 Any suggestions for how to achieve this filtering? |
Owner
|
No worries, I'm not super on top of the filtering stuff myself. |
- Added tags field on `Feed` struct - Added filter shorthand for tags - Currently filtering doesn't work :sad:
GV14982
force-pushed
the
feat/add-tag-feature
branch
from
f69418f to
6ca4e70
Compare
Contributor
Author
|
Oops, forgot to mention this closes #149 |
Owner
|
@GV14982 branch will need an update after the other changes. |
Contributor
Author
|
@guyfedwards updated. |
Owner
|
thanks @GV14982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedstruct