Add focus rings for accessibility #303
Merged
+74
−113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the task of ensuring that all keyboard-focusable elements have some sort of visual indicator when they're focused.
What was before
Previously, we were setting
outline: noneon some elements, some had focus rings but implemented usingbox-shadow(which is not ideal because high-contrast modes often remove box shadows - I've replaced them withoutlines), and others just used the user-agent focus styles (which is fine, but not consistent with our design, and sometimes the defaults are not very visible).What is now
What I've added focus rings to:
.btnbuttonsSome elements that are still missing custom focus rings: (they have the browser-provided focus rings so it's not the end of the world)
Other changes I made:
If these changes are acceptable, I would be happy to implement the rest of the focus rings as well!
Screenshots