Skip to content

Conversation

@qunabu
Copy link

@qunabu qunabu commented Dec 2, 2025

Type is wrong as function takes only one parameter

Type is wrong as function takes only one parameter
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original line is correct. The first parameter points to this as function context not argument.

@qunabu
Copy link
Author

qunabu commented Dec 2, 2025

I'll provide an not working example, it seems not be working with particular versions of TS and arrow fn callback

@qunabu
Copy link
Author

qunabu commented Dec 3, 2025

Problem is when you put this code
https://github.com/handsontable/handsontable/blob/develop/handsontable/src/editors/dateEditor/dateEditor.js#L284
into typescript

To make this definition happy it should be

origOnSelect.call(this.$datePicker);

from original

origOnSelect();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants