-
-
Notifications
You must be signed in to change notification settings - Fork 767
Update add_date_picker Summary #2448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fix typo for add_date_picker.
|
Thanks for catching this typo! Unfortunately this PR is not going to fix it because Or, alternatively, we can keep this PR open as a reminder, and one day I'll fix it myself :) (easy for me since I have everything set up for building it on my PC). |
|
Thanks for explaining! I believe I've followed your direction. Build was noted as successful. After, I ran "BuildSandboxLinux.sh" instead as I am on Ubuntu (couldn't actually find "DearPyGuiSandbox.exe"), but I hope this is equivalent. I don't see the three files you mention, so perhaps I still messed something up. I'll keep looking into it in case I missed something. |
Yep, you still need to run the sandbox. I don't have Linux at the moment and can't check it, but it should be somewhere in the build folder (probably Also, no need to commit |
|
I believe I've finally figured it out. Thank you for your patience. |
v-ein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
We'll merge it after release 2.1. |
Fix typo for add_date_picker.
name: Pull Request
about: Improve docs.
title: Update add_date_picker Summary
assignees: @Pcothren
Closes #2447
Description:
The summary of the method add_date_picker currently reads "Adds a data picker." Update changes this to read "Adds a date picker."
Concerning Areas:
None