Skip to content

Conversation

@mzimm003
Copy link

Fix typo for add_date_picker.


name: Pull Request
about: Improve docs.
title: Update add_date_picker Summary
assignees: @Pcothren


Closes #2447

Description:

The summary of the method add_date_picker currently reads "Adds a data picker." Update changes this to read "Adds a date picker."

Concerning Areas:

None

Fix typo for add_date_picker.
@mzimm003 mzimm003 requested a review from hoffstadt as a code owner December 13, 2024 02:19
@v-ein
Copy link
Collaborator

v-ein commented Jun 21, 2025

Thanks for catching this typo! Unfortunately this PR is not going to fix it because dearpygui.py is generated automatically from multiple sources. The original string is in mvAppItem.cpp. After you fix it, build DPG and run DearPyGuiSandbox.exe - it will re-generate the API files - there are three of them, including dearpygui.py. These files, even though they are generated, need to be committed together with mvAppItem.cpp.

Or, alternatively, we can keep this PR open as a reminder, and one day I'll fix it myself :) (easy for me since I have everything set up for building it on my PC).

@mzimm003
Copy link
Author

Thanks for explaining! I believe I've followed your direction. Build was noted as successful. After, I ran "BuildSandboxLinux.sh" instead as I am on Ubuntu (couldn't actually find "DearPyGuiSandbox.exe"), but I hope this is equivalent.

I don't see the three files you mention, so perhaps I still messed something up. I'll keep looking into it in case I missed something.

@v-ein
Copy link
Collaborator

v-ein commented Jun 23, 2025

I don't see the three files you mention, so perhaps I still messed something up.

Yep, you still need to run the sandbox. I don't have Linux at the moment and can't check it, but it should be somewhere in the build folder (probably cmake-build-local in the project root) and is probably named DearSandbox (see this wiki page).

Also, no need to commit scripts/BuildSandboxLinux.sh (if you're using git commit -a it will add the script automatically due to changed access mode -- be careful with that -a flag, better use explicit git add).

@mzimm003
Copy link
Author

I believe I've finally figured it out. Thank you for your patience.

Copy link
Collaborator

@v-ein v-ein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@v-ein
Copy link
Collaborator

v-ein commented Jul 3, 2025

We'll merge it after release 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in add_date_picker

2 participants