Skip to content

Conversation

@hoorak17
Copy link
Owner

Motivation

  • Improve relevance of feedback tag suggestions by making them block-aware and prioritizing tags using title keyword rules and historical usage counts.

Description

  • Add feedbackUsageCounts and a recordFeedbackUsage call from updateTodayFeedback to track tag selection frequency.
  • Introduce keywordTagRules and change feedbackOptionsFor to accept a TimeBlock and produce an ordered List<String> that prioritizes keyword-matched tags, then frequently used tags, then the remaining base tags.
  • Preserve and reuse consolidated tag lists (commonCauseTags, sleepSpecificTags, exerciseSpecificTags, studySpecificTags) and update the UI integration by changing HomeViewModel.feedbackOptionsFor and its use in HomeScreen to pass a TimeBlock instead of a Category.
  • Ensure the final suggestion list deduplicates prioritized tags while keeping all base tags available.

Testing

  • No automated tests were executed for this change.

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9910d5423d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +574 to +578
val baseTags = when (block.category) {
Category.SLEEP -> sleepSpecificTags + commonCauseTags
Category.EXERCISE -> exerciseSpecificTags + commonCauseTags
Category.STUDY -> studySpecificTags + commonCauseTags
Category.ETC -> commonCauseTags

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore ETC feedback options

For Category.ETC, feedbackOptionsFor now returns only commonCauseTags (Category.ETC -> commonCauseTags). The previous ETC options (GOOD/OKAY/BAD/FAIL) are no longer part of any base tag list, so ETC blocks can no longer surface those generic sentiment tags in the suggestion sheet. If those tags are still expected for ETC blocks, they need to be added back to the ETC base list or a new ETC-specific list, otherwise this is a user-visible regression in available feedback choices.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants