Skip to content

set peer.host to the same value as rpc.host by default #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set peer.host to the same value as rpc.host by default #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ The constructor can take the following attributes:
- `user`: JSON-RPC username (**required**)
- `pass`: JSON-RPC password (**required**)
- `peer`: P2P settings
- `host`: Peer IP to connect to (**optional.** default: 127.0.0.1)
- `host`: Peer IP to connect to (**optional.** default: same as `rpc.host`)
Copy link

@auxon auxon Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. You are a gentleman and a scholar.

- `chain`: Chain definition (optional. strongly recommended)
- `prune`: automatically prune the oldest `.tx` file inside the `chain` folder when the number of files exceeds `prune`.
- `path`: the path to store the chain files in
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class Bitwork {

// PEER
let m = new Messages({ Block: bsv.Block, BlockHeader: bsv.BlockHeader, Transaction: bsv.Transaction, MerkleBlock: bsv.MerkleBlock })
let g = Object.assign({ host: "127.0.0.1", messages: m }, (gene && gene.peer ? gene.peer : {}))
let g = Object.assign({ host: rpcconfig.host, messages: m }, (gene && gene.peer ? gene.peer : {}))
Copy link

@auxon auxon Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. ;-) Good to go.

this.peer = new Peer(g)
this.peer.on("disconnect", function() { console.log("disconnected") })
this.peer.on("error", function(e) { console.log("Err", e) })
Expand Down