[helm] Add support for external monitoring option #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
force-pushed
the
helm_monitoring_external
branch
from
b81d2ab to
ddea450
Compare
barroco
reviewed
Jan 2, 2026
deploy/services/helm-charts/dss/templates/prometheus-loadbalancers.yaml
Outdated
Show resolved
Hide resolved
deploy/services/helm-charts/dss/templates/prometheus-loadbalancers.yaml
Outdated
Show resolved
Hide resolved
deploy/services/helm-charts/dss/templates/prometheus-loadbalancers.yaml
Outdated
Show resolved
Hide resolved
deploy/services/helm-charts/dss/templates/prometheus-loadbalancers.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Barroco <michael@orbitalize.com>
…cers.yaml Co-authored-by: Michael Barroco <michael@orbitalize.com>
…cers.yaml Co-authored-by: Michael Barroco <michael@orbitalize.com>
…cers.yaml Co-authored-by: Michael Barroco <michael@orbitalize.com>
the-glu
force-pushed
the
helm_monitoring_external
branch
from
166ae3c to
f01a9f8
Compare
barroco
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the external monitoring option on helm chart as well.
Implementation is better than the tanka one, as it's support https, a following up PR will bring it up to date.