Fix unit test suite #1037
Open
Fix unit test suite #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests using BitbucketServer as git provider were failing because JF_GIT_BB_USERNAME is mandatory for that provider. Added the missing environment variable to all affected tests.
eyalk007
added
safe to test
github-actions
bot
removed
the
safe to test
The test expected validation in order: Provider → Owner → Token → Repo but the code validates: Repo → Provider → Owner → Token. Updated test to match the actual code behavior.
eyalk007
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
| SetEnvAndAssert(t, map[string]string{GitRepoOwnerEnv: "jfrog"}) | ||
| _, err = extractGitParamsFromEnvs() | ||
| assert.EqualError(t, err, "'JF_GIT_TOKEN' environment variable is missing") | ||
|
|
Contributor
There was a problem hiding this comment.
lets add the final env vars like you did each at the time and end up the test with checking we have no errors (and if you want to be very strict- check that all env vars are set correctly, although it seems there is not much to fail there)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the unit test suite bb test as it was missing a param