-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(gsm): add standardised error fields to GSM models and database schema #10600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Changed Files
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10600 +/- ##
=======================================
Coverage ? 6.44%
=======================================
Files ? 1254
Lines ? 313662
Branches ? 0
=======================================
Hits ? 20209
Misses ? 293453
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
migrations/2025-12-10-114754_add_standardised_fields_to_gsm/up.sql
Outdated
Show resolved
Hide resolved
| /// Standardised error code for the GSM rule | ||
| #[schema(value_type = Option<StandardisedCode>)] | ||
| pub standardised_code: Option<api_enums::StandardisedCode>, | ||
| /// Description of the error | ||
| pub description: Option<String>, | ||
| /// User guidance message for the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve the doc comments for these fields ?
Type of Change
Description
This PR adds new columns to the GSM (Gateway Status Mapping) table and updates the create/update APIs to include these new fields for better error categorization and user guidance.
Additional Changes
Motivation and Context
closes #10599
How did you test it?
Create Request:
Response:
Get Request :
Response:
Checklist
cargo +nightly fmt --allcargo clippy