-
Notifications
You must be signed in to change notification settings - Fork 0
Fix git config missing in reset_test.py #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add explicit git user configuration (email/name) in `setup_repo` to prevent commit failures in environments without global git config. - Add `--yes` flag to `mstl reset` command in the test to ensure it runs non-interactively as expected.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Test Coverage ReportTotal Coverage: 63.8% Detailed Report
|
The
manual_tests/reset_test.pyscript was failing because it attempted to create git commits without configuring a git user/email, which causes git to error out in environments where these are not globally configured. Additionally, the test was hanging on themstl resetprompt because it wasn't running in auto-confirm mode.This change:
user.emailanduser.namein the temporary test repository.--yesflag to theresetcommand invocation within the test to bypass the confirmation prompt.PR created automatically by Jules for task 11029969726033920909 started by @keiji