Switch -c consistency check #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to ensure all repositories are on the same branch when creating a new branch with `switch -c`. If inconsistent, prompt the user with the current status of each repository. Changes: - internal/app/switch.go: Add consistency check logic and status display. - internal/ui/ui.go: Use sys.Stdout for prompts to support testing. - internal/app/switch_test.go: Add unit test for consistency check. - manual_tests/manual_test_switch_check.py: Add manual test script. - docs/internal/app/switch.md: Update design doc. - docs/manual_tests/manual_test_switch_check.md: Add manual test doc. - manual_tests/manual_test_full.sh: Include new manual test.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Test Coverage ReportTotal Coverage: 64.1% Detailed Report
|
Owner
|
|
Contributor
Author
ステータス表示を |
Update the switch consistency check to display the full status table (reusing status command logic) instead of a simple list when branches do not match. Changes: - internal/app/switch.go: Use `CollectStatus` and `RenderStatusTable`. - internal/app/switch_test.go: Verify table output format. - manual_tests/manual_test_switch_check.py: Check for table headers in output.
Test Coverage ReportTotal Coverage: 64.1% Detailed Report
|
Owner
|
Contributor
Author
Fixed manual tests failures. |
Fix failures in manual tests reported in PR review. - Fix manual_test_switch_remote.py to set git user config. - Fix manual_test_switch_check.py to use `git checkout -B` for robustness. - Fix internal/app/run.go to print fatal errors to Stderr instead of Stdout, fixing manual_test_config_search.py expectations and adhering to CLI standards. Changes: - internal/app/run.go: Print error to os.Stderr. - manual_tests/manual_test_switch_remote.py: Configure git user. - manual_tests/manual_test_switch_check.py: Use -B flag.
Test Coverage ReportTotal Coverage: 64.1% Detailed Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement consistency check for
switch -ccommand. Checks if all local branches match before creating/switching. If not, prompts user with a list of current branches.PR created automatically by Jules for task 8979327570226183598 started by @keiji