AP-25492: Set KDS legacy mode in Python scripting editor #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables KDS (KNIME Design System) legacy mode in the Python scripting editor to fix a display issue where legacy styling was not being applied to KDS components in scripting dialogs.
Key changes:
- Enabled KDS legacy mode globally in the application initialization
- Added required KDS stylesheets for legacy theme support
- Added
@knime/kds-componentsdependency and downgraded@vueuse/core
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| org.knime.python3.scripting.nodes/js-src/src/main.ts | Imports and enables KDS legacy mode at application startup |
| org.knime.python3.scripting.nodes/js-src/src/components/App.vue | Imports KDS legacy theme CSS files |
| org.knime.python3.scripting.nodes/js-src/package.json | Adds KDS components dependency and adjusts VueUse version |
Files not reviewed (1)
- org.knime.python3.scripting.nodes/js-src/package-lock.json: Language not supported
AP-25492 (Scripting Editor dialogs do not show legacy mode for KDS components)
HedgehogCode
force-pushed
the
bug/AP-25492-kds-legacy-mode
branch
from
3bd9776 to
f15caea
Compare
|
dsaam94
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP-25492 (Scripting Editor dialogs do not show legacy mode for KDS components)