use updated do-not-disrupt annotation #1379
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwmetcalf
force-pushed
the
update-annotation
branch
from
60e7003 to
758758d
Compare
Member
|
Hi @bwmetcalf - thanks for the PR. It broke the Karpenter test, can you please look into the issue and fix it? You will also need to update hashed by running |
Author
Thanks @realshuting. |
* Converting ClusterPolicy to MutatingPolicy [patch 4] Signed-off-by: Mohab Yaser <mohabyaserofficial2003@gmail.com> * updating artifacthub-pkg Signed-off-by: Mohab Yaser <mohabyaserofficial2003@gmail.com> * fix: add permissions Signed-off-by: ShutingZhao <shuting@nirmata.com> * fixing resolve-image-to-digest Signed-off-by: Mohab Yaser <mohabyaserofficial2003@gmail.com> * fixing label-nodes-cri Signed-off-by: Mohab Yaser <mohabyaserofficial2003@gmail.com> * fix: adapt new .resolvedImage format Signed-off-by: ShutingZhao <shuting@nirmata.com> * chore: temp remove the CLI test Signed-off-by: ShutingZhao <shuting@nirmata.com> * chore: update hashes Signed-off-by: ShutingZhao <shuting@nirmata.com> --------- Signed-off-by: Mohab Yaser <mohabyaserofficial2003@gmail.com> Signed-off-by: ShutingZhao <shuting@nirmata.com> Co-authored-by: ShutingZhao <shuting@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
…erno#1378) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.0.0 to 6.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@4469467...4dc6199) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 6.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.2.2...1af3b93) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
* add dir in ci Signed-off-by: Mohd Kamaal <mohdcode@MacBook-Air.local> * correction in test.yaml Signed-off-by: Mohd Kamaal <mohdcode@MacBook-Air.local> * update policy-ready Signed-off-by: Mohd Kamaal <mohdcode@MacBook-Air.local> * fix assertion file Signed-off-by: Mohd Kamaal <mohdcode@MacBook-Air.local> * lint fix Signed-off-by: Mohd Kamaal <mohdcode@MacBook-Air.local> --------- Signed-off-by: Mohd Kamaal <mohdcode@MacBook-Air.local> Co-authored-by: Mohd Kamaal <mohdcode@MacBook-Air.local> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: ShutingZhao <shuting@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@1af3b93...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
Signed-off-by: Brandon Metcalf <brandon.metcalf@umbra.space>
bwmetcalf
force-pushed
the
update-annotation
branch
from
bb1a460 to
5aafcb1
Compare
Author
|
@realshuting Could you review and approve or let me know if anything else is needed? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates example to reflect new
karpenter.sh/do-not-disruptannotation.karpenter.sh/do-not-evictwas deprecated and then removed in karpenter v1.0.0. https://karpenter.sh/v1.0/upgrading/v1-migration/#deprecated-annotations-labels-and-tags-removed.Checklist