-
Notifications
You must be signed in to change notification settings - Fork 117
feat: new status manager (old ui) #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9bdacb5 to
0a57dd2
Compare
| async getWalletAdapter() { | ||
| return currentWallet?.adapter as SignerWalletAdapter | ||
| async getWallet() { | ||
| return currentWallet?.adapter as SignerWalletAdapter as any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed for latest SDK - hotfix, possibly requires more updates
| sdkConfig: { | ||
| apiUrl: 'https://li.quest/v1', | ||
| preloadChains: false, | ||
| preloadChains: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally linked SDK does not preserve SDK client storage chains -> revert before merging.
| chainId, | ||
| skipReady, | ||
| }: { | ||
| client?: Client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hotfix for latest SDK
| }) | ||
|
|
||
| const lastActiveStep = route?.steps.findLast((step) => step.execution) | ||
| const lastActiveProcess = lastActiveStep?.execution?.process.at(-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Execution now stores the last active process type and status
| import { useExecutionMessage } from '../../hooks/useExecutionMessage.js' | ||
| import { CircularProgress } from './CircularProgress.js' | ||
|
|
||
| export const StepExecution: React.FC<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to StepTransaction (or previously StepProcess) , but without links.
step.execution.status is marked as "DONE" only on the very last step (when all the processes would be "DONE"). We don't want to show it in this case since the last transaction in step.execution.transactions would correspond to it.
| "zod": ">=4.1.11" | ||
| "zod": ">=4.1.11", | ||
| "@reown/appkit": ">=1.8.15", | ||
| "@lifi/sdk": "link:../../Library/pnpm/global/5/node_modules/@lifi/sdk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Remove before merging - needed for local linking.
| return { title } | ||
| } | ||
|
|
||
| export function getTransactionMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as getExecutionMessage(), shows transactions of "DONE" processes.
|
Closing since different changes are to be applied to SDK. |
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-17289
Why was it implemented this way?
This PR aligns the widget with new SDK status manager: lifinance/sdk#340
Process array-based structure is now replaced with a simpler Execution + Transaction model:
step.execution.process[]array withstep.executionobject +step.execution.transactions[]statusandsubstatusare stored - directly on execution instead of individual process itemsRouteExecutionUpdatenow passexecutioninstead ofprocess.Visual showcase (Screenshots or Videos)
Visually, this part of the execution page is affected:

Now, instead of the list of processes, we show successfully completed
step.execution.transactions[](previously processes with status "DONE") and current status and message recorded instep.execution.Checklist before requesting a review