chore: Add gasprice flag for RLN membership registration #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Ivansete-status should this be a Draft PR for now? |
|
You can find the image built from this PR at Built from 7356a33 |
Ivansete-status
approved these changes
Nov 14, 2025
Collaborator
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
LGTM! Thanks for it! 💯
|
|
||
| test "register: should use max gas price when useMaxGasPrice flag is set": | ||
| (waitFor manager.init()).isOkOr: | ||
| raiseAssert $error |
Collaborator
There was a problem hiding this comment.
Maybe?
Suggested change
| raiseAssert $error | |
| assert false, "Failed to init group manager: " & $error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is related to an issue observed by DST when trying to register multiple RLN memberships consecutively with the
generateRlnKeystorecommand.An overflow error was observed for the gasprice.
I doubt we need to make this a permanent change, but it could help us understand the issue seen by DST and allow them to complete testing.
Changes
Add a flag to the
generateRlnKeystorecommand to use a much larger gasprice than should ever be needed which will mainly be used for testing purposesRegistration method in group_manager updated to recognise this flag
relates to #3643