-
Notifications
You must be signed in to change notification settings - Fork 57
feat: support SARIF output formatter #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
alerque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the SARIF output format sounds great. I'm sure there is legitimate uses for that ... I'm not convinced showing up in the "security" tab is what we want to have happen though. Most of the code lints luacheck produces are not likely to be security related.
Also a bit of a concern about deterministic testing...see code comments.
|
SARIF is a |
|
It's awesome! I'm using megalinter in my project, which using multiple languages, including lua. So an united output format is needed. |
SARIF can be used by GitHub Code Scanning feature, which ill produce reports avaliable from the GitHub Security tab. I haven built a sample repository for the PR, you can use this sample repository to see the general effect.
In Security Tab: https://github.com/yeshan333/luacheck_sarif_report_demo/security/code-scanning
In Pull Request: yeshan333/luacheck_sarif_report_demo#1