Skip to content

feat: add size property to bar and line chart plugins #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
skokenes wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add size property to bar and line chart plugins #2446

skokenes wants to merge 2 commits into from

Conversation

@skokenes
Copy link
Contributor

@skokenes skokenes commented Jul 18, 2025 •
edited
Loading

Summary

Exposes the viz size property in bar and line plugin settings

Changes

  • Added size property to BarChartSettings and LineChartSettings interfaces
  • Updated JSON Schema definitions for both chart types to include size validation
  • Implemented size tag parsing in getBarChartSettings and getLineChartSettings functions
  • Integration with existing chart layout infrastructure (no changes needed to vega spec generators)

Usage

Users can now specify chart sizes in two ways:

  1. Preset sizes: xs, sm, md, lg, xl, 2xl

    # viz=bar { size=lg }

  2. Custom dimensions: specific width and height values

    # viz=line { size.width=400 size.height=200 }

Test plan

  • All existing tests pass
  • Build completes successfully
  • Linting passes
  • Manual testing with example queries using the new size property

@skokenes @claude
feat(render): add size property to bar and line chart plugins
7034dc7 
Adds support for the size property in bar and line chart visualization tags.
Users can now specify chart sizes using either presets or custom dimensions:
- Preset sizes: xs, sm, md, lg, xl, 2xl (e.g., # viz=bar { size=lg })
- Custom dimensions: width and height (e.g., # viz=line { size.width=400 size.height=200 })

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@skokenes skokenes changed the title feat(render): add size property to bar and line chart plugins feat: add size property to bar and line chart plugins Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

render

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skokenes