Publisher: Add create, update, and delete connection to API #423 #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jellysaini <jellysaini.1987@gmail.com>
…loydata/publisher into presist-CRUD-state-in-duckDB-cleaner
sagarswamirao
requested changes
Dec 15, 2025
…com:malloydata/publisher into add-create-update-and-delete-connection-API
sagarswamirao
approved these changes
Dec 16, 2025
Collaborator
|
I think you forgot adding the tests. Can you add the tests please? |
sagarswamirao
requested changes
Dec 16, 2025
Collaborator
Author
|
Hey @sagarswamirao, I have added the tests. Please have a look. |
sagarswamirao
requested changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created this PR before we merge/approve this PR into main. We have to merge the below PR to main.
#503