Move prebuildify to dev dependencies #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderBelokon
approved these changes
Jul 1, 2025
AlexanderBelokon
force-pushed
the
move-prebuildify-to-dev
branch
from
6031c02 to
6c269f5
Compare
…system toolchain when MASON_LLVM_RELEASE="system" is set in the CI environment.
Closed
rafaykh90
reviewed
Jul 2, 2025
| elif [[ -d ${GLOBAL_CLANG} ]]; then | ||
| echo "Detected '${GLOBAL_CLANG}/bin/clang++', using it" | ||
| local llvm_toolchain_dir=${GLOBAL_CLANG} | ||
| elif [[ "${MASON_LLVM_RELEASE}" == "system" ]]; then |
Contributor
There was a problem hiding this comment.
This was the only thing I was missing all along, I even tried to upgrade llvm in mason packages. Thanks for fixing this. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes STUDIO-3808