-
Notifications
You must be signed in to change notification settings - Fork 267
fix: Upgrade tar package to ^7.5.3 - CVE-2026-23745 - HIGH #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request upgrades the tar package from version ^7.4.0 to ^7.5.3 to address a security vulnerability referenced as CVE-2026-23745.
Changes:
- Upgrades tar package to version 7.5.3
- Upgrades minizlib dependency from 3.0.1 to 3.1.0
- Removes several transitive dependencies (jackspeak, @isaacs/cliui, mkdirp, rimraf, and others) that are no longer required
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates tar dependency version from ^7.4.0 to ^7.5.3 |
| package-lock.json | Updates tar to 7.5.3, minizlib to 3.1.0, removes obsolete transitive dependencies, and adjusts peer dependency markers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
% aws-sdk >=2.0.1 1 low severity vulnerability https://www.npmjs.com/package/aws-sdk -->
https://github.com/aws/aws-sdk-js |
|
@cclauss |
We have investigated the uses of the tar dependency and found two use cases of it in our code base's supply chain: - electron-builder - grpc-tools (from their use of @mapbox-node-pre-gyp) Currently the tar dependency update has not traversed all through the supply chain in the packages we depend on. electron-builder and their supply chain was very fast to bump the dependency, but it seems like @mapbox/node-pre-gyp do not currently have an update available, currently. A draft PR does exist though. Link to draft PR for @mapbox/node-pre-gyp tar upgrade: mapbox/node-pre-gyp#933 When this has been patched we should update immediately. --- Extended reasoning on ignoring the vulnerable dependency: The vulnerable tar dependency does not handle arbitrary tar files, as it is only used by grpc-tools. Unless the specific tar file, corresponding to the version of grpc-tools we depend on, is compromised then an attack is not possible. The tar file is hosted on Github's package repository and for an attack to be possibe either the grpc-tools team or Github's package repostitory must be compromised, which currently seems unlikely. However, even if unlikely we still want to ensure that we can protect against this attack and if a patch hasn't been made available at the end of this ignore period we will want to investigate other forms of mitigation.
Fixes: #932