MLE-26420 Can now perform incremental writes #1868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR introduces an incremental write feature that prevents unnecessary document writes by comparing hash values of document content. The implementation uses a field-based hash stored in MarkLogic to determine if a document's content has changed since its last write, skipping writes for unchanged documents.
Key Changes:
- Added
IncrementalWriteFilterwith two retrieval strategies: Optic queries and server-side eval - Implemented JSON canonicalization to handle key ordering differences
- Added comprehensive test coverage for the incremental write functionality
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test-app/src/main/ml-config/databases/content-database.json | Adds field and range-field-index configurations for incrementalWriteHash field |
| marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteTest.java | Integration tests for incremental write with Optic and eval filters, JSON canonicalization scenarios |
| marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilterTest.java | Unit tests for metadata handling without database connection |
| marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteOpticFilter.java | Optic-based implementation for retrieving existing hash values |
| marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java | Core filter logic with Builder pattern for customization |
| marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteEvalFilter.java | Server-side JavaScript eval implementation for hash retrieval |
| marklogic-client-api/build.gradle | Adds dependencies for JSON canonicalization and hash generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...lient-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java
Outdated
Show resolved
Hide resolved
...lient-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java
Show resolved
Hide resolved
...t-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteEvalFilter.java
Outdated
Show resolved
Hide resolved
rjrudin
force-pushed
the
feature/26420-eval-query
branch
from
093f7ea to
2b6294e
Compare
BillFarber
reviewed
Dec 31, 2025
| @Override | ||
| public DocumentWriteSet apply(DocumentWriteSetFilter.Context context) { | ||
| ArrayNode uris = new ObjectMapper().createArrayNode(); | ||
| for (DocumentWriteOperation op : context.getDocumentWriteSet()) { |
Contributor
There was a problem hiding this comment.
nitpick - I would use a different variable name than "op" just to avoid confusion with optic DSL (particularly because of IncrementalWriteOpticFilter below).
Contributor
Author
There was a problem hiding this comment.
I had that exact same thought yesterday and I know I changed it to "doc" somewhere else, will definitely change it here. I think Copilot spits out "op" by default.
BillFarber
previously approved these changes
Dec 31, 2025
IncrementalWriteFilter is the entry point, with a Builder for customizing its behavior.
rjrudin
force-pushed
the
feature/26420-eval-query
branch
from
2b6294e to
ad22dcb
Compare
BillFarber
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IncrementalWriteFilter is the entry point, with a Builder for customizing its behavior.